New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use structs that impl Display for escaping #881
base: master
Are you sure you want to change the base?
Conversation
Looks very good and smart to me! But I think we need to test the performance penalty before merging it. Thanks! |
Not so great:
|
If this performance downgrade is not due the compilation flags, I think we should try to improve the performance of this approach before merging it because the performance regression is significant. |
I have run the benchmarks with the Cargo.toml optimizations and the difference of performance hurts 😞 :
|
I guess it's pretty conclusive anyway but |
It has many outliers and maybe there are instruction cache misses? I don't know, I executed the benchmarks without executing other CPU-intensive tasks, but an additional benchmark would be desirable to verify the performance loss. |
Stacked on top of #880
As discussed in #870 (comment), instead of
write
At the same time we can make
StrWrite
and friends private and less complicated.I haven't evaluated the performance implications of this yet.