Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three changes here. (1) could be done without the other two to fix the bug.
(2) & (3) might have some small performance implications in some cases. However, they should make it easier to disallow empty display math items
$$$$
, which I'm planning to do in a follow-up PR.Populate
math_delims
fully instead of stopping at an invalid closing delimiter. Inline code already works like this, though it can't encounter invalid delimiters.Fixes a bug when parsing e.g. this:
$x {$ $ } $x$
Disallow
$$
matching a closing$
and then marching delimiters inmake_math_span
. Instead, retry scanning at the second position (really just amath_delims.find()
).Before:
After:
Remove the
seen_first
optimization fromMathDelims
. It doesn't work with the retry strategy (2).