"Fix" GFM tasklist rendering

[bobhy]

Resolves the issues raised in #805.

Changes html rendering for GFM tasklists from:

<p>Old task list</p>
<ul>
<li><input disabled="" type="checkbox"/>do it</li>
<li><input disabled="" type="checkbox" checked=""/>done</li>
</ul>
<p>
New task list
</p>
<ul>
<li style="list-style-type: '\2610   ';">to do</li>
<li style="list-style-type: '\2612   ';">done</li>
</ul>

Which renders as:

Apparently the former rendering is specified in Commonmark specs, so we should raise the question, potentially get a blessing from them. What's that process?

I don't know when list-style-type: <string> was released in CSS. Current Firefox, Edge and Chrome browsers support it, someone will need to try Safari.

\2612 for the "checked" marker renders as a box with an X, not a checkmark. That's my personal preference, but it's just Unicode and there's a \2611 that has the checkmark.

This is a modestly breaking change (for code that depends on HTML output). Should there be an old_gfm_task_render feature?

[notriddle]

This seems like another feature to put on the pile of #645

Your rendering makes more sense for non-interactive lists (like mdBook), but the <input>-based rendering is what GitHub uses (that way, you can actually click the checkbox). The parser doesn't know if you're an interactive app or not.

A more robust HTML generator than pulldown-cmark has can expose a configuration option to pick between these modes.

[bobhy]

OK. Yet another enhancement request that's not quite ready for prime time. Meantime, I've got my private repo integrated with Zola and am able to use it for what I needed. Is there any energy about doing a new release of the project? Enhancements are always nice, though the simple bug reports seem to be piling up. I've got some time and interest, would be willing to join the fun. My idea would be to focus first on a bug-fix release. That gives you more time to design thoughtful enhancements or add ons and the confidence that you've got a solid codebase to work from. I could take a crack at identifying issues that might be good candidates for such a release, hopefully that makes it easier for others who have time to know where to pitch in.

…

On Wed, Jan 10, 2024 at 12:58 PM Michael Howell ***@***.***> wrote: This seems like another feature to put on the pile of #645 <#645> Your rendering makes more sense for non-interactive lists (like mdBook), but the <input>-based rendering is what GitHub uses (that way, you can actually click the checkbox). The parser doesn't know if you're an interactive app or not. A more robust HTML generator than pulldown-cmark has can expose a configuration option to pick between these modes. — Reply to this email directly, view it on GitHub <#806 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPBIZHT6PVJJQFBGA2G6WTYN3JEXAVCNFSM6AAAAABBSPTJ7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGM2TANBSHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[notriddle]

I'm not the maintainer and can't really set project direction for pulldown-cmark. It's up to @raphlinus and @Martin1887 when and how the next release will go out.

[Martin1887]

Hello, the 0.10 version will be released when the pending pull requests are merged, hopefully this month.

However, new contributors are welcome, and indeed I had planned creating a new issue asking for contributors after the 0.10 release. To join as contributor, it is recommended to have a meeting with @raphlinus, and it is required respecting the rule of not merging pull requests or commits to the master branch without approval from another person.

@notriddle, @ollpu and @mgeisler are good candidates, based on previous contributions, but everyone is welcome.

Thanks!

[ollpu]

Hey, thanks for the recognition. I'm open to dedicating some on-and-off time to maintaining the project.

[Martin1887]

Hi, the project has been moved to a new organization and I have invited @ollpu and @notriddle to join as contributors of the project.

I have just created a v0.11 milestone with the most important issues for the 0.11 release, but discussion is open to add other ones.

[mgeisler]

@notriddle, @ollpu and @mgeisler are good candidates, based on previous contributions, but everyone is welcome.

I would be happy to contribute where possible, but I have to admit that I find it hard to find time for my own crates these days... I'll of course keep trying to add a comment here and there when I find time 😄

[Martin1887]

This change is more adequate in an alternative renderer, as @notriddle said, and it is already added in the tracking issue.