Merge pull request #877 from notriddle/link-title-break

Eat all spaces after line break in link title
pulldown-cmark · Apr 16, 2024 · 6165d35 · 6165d35
2 parents 912405c + e589720
commit 6165d35
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/pulldown-cmark/specs/regression.txt b/pulldown-cmark/specs/regression.txt
@@ -2542,3 +2542,15 @@ ISSUE 861
 .
 <pre><code></code></pre>
 ````````````````````````````````
+
+ISSUE 867
+
+```````````````````````````````` example
+[link]: destination "
+          text          "
+
+[link]
+.
+<p><a href="destination" title="
+text          ">link</a></p>
+````````````````````````````````
diff --git a/pulldown-cmark/src/firstpass.rs b/pulldown-cmark/src/firstpass.rs
@@ -1634,6 +1634,7 @@ impl<'a, 'b> FirstPass<'a, 'b> {
                             return None;
                         }
                     }
+                    line_start.scan_all_space();
                     bytecount += line_start.bytes_scanned();
                     linestart = bytecount;
                     if scan_blank_line(&bytes[bytecount..]).is_some() {

diff --git a/pulldown-cmark/tests/suite/regression.rs b/pulldown-cmark/tests/suite/regression.rs
@@ -3039,3 +3039,17 @@ fn regression_test_192() {
 
     test_markdown_html(original, expected, false, false, false);
 }
+
+#[test]
+fn regression_test_193() {
+    let original = r##"[link]: destination "
+          text          "
+
+[link]
+"##;
+    let expected = r##"<p><a href="destination" title="
+text          ">link</a></p>
+"##;
+
+    test_markdown_html(original, expected, false, false, false);
+}