Add rake task to clear bad thumbnails in an ephemera box #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
changed the title
I kept hitting this undefined constant error, see deivid-rodriguez/byebug#564 to use debug insert `binding.break`
hackartisan
force-pushed
the
6081-box-8-bad-thumbnails
branch
from
3e81017
to
9dc6bca
Compare
Uses a service which sets the first member fileset as the new thumbnail
hackartisan
force-pushed
the
6081-box-8-bad-thumbnails
branch
from
7bd59a1
to
fee9007
Compare
eliotjordan
requested changes
Nov 29, 2023
|
|
||
| describe ".call" do | ||
| context "when given an ephemera box id" do | ||
| it "deletes FileSets which were set as thumbnails but have no parent" do |
There was a problem hiding this comment.
suggestion: Update this description as the service doesn't delete FileSets. Something that relays how the orphan file set is unset as the thumbnail?
| end | ||
| end | ||
|
|
||
| context "when the no thumbnail resource doesn't exist and there are no members" do |
There was a problem hiding this comment.
issue: small typo. "when the no thumbnail" -> "when the thumbnail"
eliotjordan
reviewed
Nov 29, 2023
| attr_reader :box_id | ||
| def initialize(box_id:) | ||
| @box_id = box_id | ||
| raise InvalidResourceTypeError unless box.is_a? EphemeraBox |
There was a problem hiding this comment.
💯 This is great. Exit early if not the correct resource type.
|
Thanks for catching those @eliotjordan -- take another look? |
eliotjordan
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binding.breakrefs #6081