Added more checks #3428
Open
Added more checks #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no change log for this pull request yet. |
victor-0x29a
reviewed
Mar 4, 2024
Comment on lines
318
to
+323
| if (debug && node.debug !== false && node.type !== 'Block') { | ||
| if (typeof node.line !== 'number') { | ||
| throw new Error( | ||
| 'node.line is not a valid number.' | ||
| ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (debug && node.debug !== false && node.type !== 'Block') { | |
| if (typeof node.line !== 'number') { | |
| throw new Error( | |
| 'node.line is not a valid number.' | |
| ); | |
| } | |
| if (debug && node.debug !== false && node.type !== 'Block' && typeof node.line === 'number') { |
isnt should better?
There was a problem hiding this comment.
It would, but that meant that it’s checking for all three instead of checking for the required two and failing silently. Throwing an error is better as it can alert the user that there may be a pollution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If templateName gets injected attackers can inject arbitrary code.
Example payload:
templateName="a(){}; function template (locals) {var pug_html = process.mainModule.require('fs').readFileSync('/etc/passwd').toString(), pug_mixins = {}, pug_interp;var pug_debug_filename, pug_debug_line;try {;//"Checks are added to restrict template names to
0-9, a-z, A-Z, -, _Special conditions are needed for this to happen and proper circumstances are needed for this vulnerability to be triggered.
Additionally, if node.line get affected due to prototype pollution code is also injectable
Example payload:
Object.prototype.block = {"type": "Text", "line": "console.log(process.mainModule.require('child_process').execSync('id').toString())"};Reference: https://po6ix.github.io/AST-Injection/
A check is added to to ensure the line number is really a line.
#3414 is also worth a follow up, and maps could be used for options to prevent prototype pollution but changing all of those may break some things so I did not touch those.