Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filters to read non-text include files #3213

Merged
merged 10 commits into from May 19, 2020
Merged

Allow filters to read non-text include files #3213

merged 10 commits into from May 19, 2020

Commits on May 2, 2020

  1. feat: add options.skipEncoding() to pug-load.read() 

    This allows Pug to correctly read non-utf8 files, if the user wants to
do such a thing.

The optional function takes the same arguments as load.read(), and
should return a truthy/falsey value. If truthy, load.read() will NOT
specify an encoding when it reads the file from disk. Otherwise, it will
continue to specify "utf-8" as the encoding.
    @brewingcode
    brewingcode committed May 2, 2020
    Copy the full SHA
    2062747 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Move encoding of file from load.read() to load.file()

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    df0a1e1 View commit details
    Browse the repository at this point in the history

  2. Keep a copy of each loaded file as the raw Buffer 

    This lives next to the existing `file.str` property.
    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    f8bd002 View commit details
    Browse the repository at this point in the history

  3. Update jest snapshot for pug-load

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    8ea501e View commit details
    Browse the repository at this point in the history

  4. Check for renderBuffer property of filter to pass Buffer to the filter

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    6d99012 View commit details
    Browse the repository at this point in the history

  5. Remove un-needed skipEncoding property from allowed options

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    1db19d2 View commit details
    Browse the repository at this point in the history

  6. Fix wrong var name

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    c303124 View commit details
    Browse the repository at this point in the history

  7. Format to make prettier feel pretty

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    34e172e View commit details
    Browse the repository at this point in the history

  8. Serialize "Buffer" types for better readability in jest snapshots 

    These render as objects with `type: "Buffer"`, along with the `size` and
`hash` of the data in the buffer.
    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    425f44a View commit details
    Browse the repository at this point in the history

  9. Appease prettier

    @brewingcode
    brewingcode committed May 6, 2020
    Copy the full SHA
    017711c View commit details
    Browse the repository at this point in the history