Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing semicolon #2962

Merged
merged 4 commits into from
Feb 19, 2018
Merged

Trailing semicolon #2962

merged 4 commits into from
Feb 19, 2018

Commits on Feb 16, 2018

  1. Only put trailing semicolon when merging style attributes 

    This is a first draft that tries to maintain the same code behavior
without worrying too much about the code quality
    @marcel0ll
    marcel0ll committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b9af5bc View commit details
    Browse the repository at this point in the history

  2. Update tests so they reflect the new code behavior 

    All style attributes that received a String won't generate
a trailing semicolon
    @marcel0ll
    marcel0ll committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    13ac11d View commit details
    Browse the repository at this point in the history

  3. Improve merge trailing semicolon code 

    Check if String is not empty by checking if it its true ('' is false)
Get last character of the string using slice(-1)
Add semicolon if the last string character is not a semicolon
    @marcel0ll
    marcel0ll committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    5e01015 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Use array style indexing instead of .slice to get last character

    @ForbesLindesay
    ForbesLindesay committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    a8354ff View commit details
    Browse the repository at this point in the history