Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: deprecated client sass, blueprint sass, bump mudder #2101

Merged
merged 7 commits into from Jun 29, 2022
Merged

Fix: deprecated client sass, blueprint sass, bump mudder #2101

merged 7 commits into from Jun 29, 2022

Conversation

howebenhowe
Copy link
Contributor

@howebenhowe howebenhowe commented Jun 28, 2022 •
edited

For those of us tired of getting the dart-sass deprecation warning on / division and the mudderjs warning on bum package.json style.

Used sass-migrator package against both the pubpub scss and the @blueprintjs/core package, then saved the changes to @blueprintjs/core using patch-package package. Also, optimistically adds quietDeps: true to dev webpack config, though it seems like it's not working yet.

@howebenhowe howebenhowe requested a review from idreyn June 28, 2022 14:25
@howebenhowe
Copy link
Contributor Author

sass/dart-sass#672

@howebenhowe howebenhowe changed the title Fix deprecated sass, silence blueprint sass deprecation warnings Fix: deprecated client sass, blueprint sass, bump mudder Jun 29, 2022
@howebenhowe howebenhowe marked this pull request as ready for review June 29, 2022 00:48
@howebenhowe howebenhowe requested a review from 3mcd June 29, 2022 00:48
@pubpubBot pubpubBot temporarily deployed to pubpub-pipel-bh-node-sa-or7qgs June 29, 2022 17:50 Inactive
idreyn
idreyn reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@idreyn idreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

idreyn
idreyn approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@idreyn idreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw jeez I always forget to approve

@pubpubBot pubpubBot temporarily deployed to pubpub-pipel-bh-node-sa-4mk9we June 29, 2022 18:38 Inactive
@idreyn idreyn merged commit 5a8fdfc into master Jun 29, 2022
@idreyn idreyn deleted the bh/node-sass-migration branch June 29, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idreyn idreyn idreyn approved these changes

@3mcd 3mcd Awaiting requested review from 3mcd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@howebenhowe @idreyn @pubpubBot