Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ruby's official image on Dockerfile #55

Closed
wants to merge 1 commit into from

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented Jun 7, 2020

Fixes #54

I'd like to get #58 merged before merging this, since we'll be able to test this out more properly.

@alaxalves alaxalves changed the title Using ruby's official image on Dockerfile WIP: Using ruby's official image on Dockerfile Jun 7, 2020
@icarito
Copy link
Member

icarito commented Jun 7, 2020 via email

@alaxalves
Copy link
Member Author

But why? Debian gives us very long support. They actually backport security patches. I'm in favor of sticking to Debian where possible, unless there's a compelling reason to switch. El dom, 7 de jun de 2020 a las 12:47, Álax de Carvalho Alves notifications@github.com escribió:

Fixes #54 <#54> You can view, comment on, or merge this pull request online at: <#55> Commit Summary Using ruby's official image on Dockerfile File Changes M Dockerfile https://github.com/publiclab/mapknitter-exporter-sinatra/pull/55/files#diff-3254677a7917c6c01f55212f86c57fbf (4) Patch Links: https://github.com/publiclab/mapknitter-exporter-sinatra/pull/55.patch https://github.com/publiclab/mapknitter-exporter-sinatra/pull/55.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQYSYGT3HDZCTZKZOFLSTRVPVGXANCNFSM4NXSPFHA.

Debian's raw image comes with several packages we don't need besides requiring the need for us to install ruby* packages in it. If we use a ruby:2.4.6-buster image for example we dismiss the need of a ruby pkg installation. It also comes with ruby* ready to go in an optimized image

@alaxalves
Copy link
Member Author

In here we wouldn't stop using Debian Buster, we just take advantage of it by setting a ruby image set on top of a debian buster image.

@alaxalves alaxalves changed the title WIP: Using ruby's official image on Dockerfile Using ruby's official image on Dockerfile Jun 10, 2020
@jywarren
Copy link
Member

Hmm. Does ruby:2.4.6-buster have the same backports, and is there a difference in the speed or schedule of releases that would present pros/cons?

@alaxalves are there any cons you can think of so we can understand any tradeoffs well? Thank you both for thoroughness!

@jywarren
Copy link
Member

Just wondering if you'd had a moment to think on this, @alaxalves ! Thanks a ton!!!

@alaxalves
Copy link
Member Author

Just wondering if you'd had a moment to think on this, @alaxalves ! Thanks a ton!!!

I'll do this for sure. I just had been focusing on other activities lately

@alaxalves
Copy link
Member Author

The backport supporting is the same, the Ruby community is as wide as the Debian community. I'm closing this since it feels it does not aggregate much for the project

@alaxalves alaxalves closed this Jul 12, 2020
@alaxalves alaxalves deleted the fix/dockerfile branch July 12, 2020 00:01
@jywarren
Copy link
Member

Thanks, Alax! Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use official Ruby image as base from Dockerfile
3 participants