feat: add styleguide #760
Merged
feat: add styleguide #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/neontribe/gbptm/9fxstxrvm |
marxian
previously approved these changes
Jun 4, 2020
|
@falconx I'm not clear about whether to merge this at this point? |
|
@marxian I'm happy for it to be merged. I just didn't want it to interfere with the transition nextjs. But, since that work is not happening right now, there shouldn't be a problem. |
stphnnnn
previously approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not a good idea to merge this before a transition to NextJS. I can port this code afterwards if that does go ahead.
I'm also keeping an eye on reactjs/react-docgen#352 which will allow for the styled system props to be documented.