ADD RxJsonSchema generic #1097
Merged
ADD RxJsonSchema generic #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed http-server from |
|
close #1093 |
|
jfhbrook/node-ecstatic#256 will fix http-server |
phil-lgr
force-pushed
the
generic-rx-json-schema
branch
from
1c643d8
to
cae728f
Compare
|
I fixed my commit, I forgot to push something, waiting on CI and we should be good? is the v8.1.1 ok? @pubkey |
pubkey
reviewed
May 3, 2019
CHANGELOG.md
Outdated
|
|
||
| Typings: | ||
| - `RxDocument.getAttachment()` and `RxDocument.allAttachments()` did not return promises | ||
|
|
||
| ### 8.1.1 (2 May 2019) | ||
|
|
||
| Typings: |
There was a problem hiding this comment.
Add your changes to the coming-soon block. Because I do not know atm when the next release will be and this would lead people into beleaving that 8.1.1 is already released.
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "rxdb", | |||
| "description": "A realtime Database for the Web", | |||
| "version": "8.1.0", | |||
| "version": "8.1.1", | |||
There was a problem hiding this comment.
Do not change the version. This will happen on release.
UPDATE(docs) update RxJsonSchema w generic example
phil-lgr
force-pushed
the
generic-rx-json-schema
branch
from
cae728f
to
1584603
Compare
|
Updated the version and README.md! Thanks! |
|
Awesome. Thank you very much. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
Make RxJsonSchema optionally generic to have type checking on
propertiesandrequired.Todos