-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin): settings ui #4866
base: develop
Are you sure you want to change the base?
feat(admin): settings ui #4866
Conversation
I've didn't see your PR #4733 @omametech. |
@alexevladgabriel Google analytics are not present anymore in the latest panel release See: |
Google Analytics was not added by me, it was already existent setting in the v2. I would love to integrate other solutions for analytics, more focussed on privacy.
I will indeed remove it from UI. |
Require to find a better method for data passing between main component & childrens, maybe |
Remained to handle the updates with backend. |
I feel like the settings UI with all of the boxes gets really cluttered and convoluted, I could PR something off this to try and clean it up. Glad to see some work in public pterodactyl, it's been a long time. |
@alexevladgabriel What do you think about the changes I said above? |
I've looked into more designs from multiple sources & real apps usage. My only issue with the current design would be that there are to many box in boxes. I like the separation of the settings based on tabs (pages). At this moment there isn't enough content, to fill the pages and can be "really cluttered and convoluted" how you said. I will look more on design ideas, sketches in remaining time and attach here some screenshots. |
In terms of this PR, worry about functionality. Before any of the v2 changes get properly released there will be multiple polish passes on the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewpi is a good idea to use transformers for settings page, for me at least it seems more boilerplate code?
First task done:
Backend
Settings
Frontend
General Settings
Security Settings
Advanced Settings