Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InteractiveMultiselectPrinter to optionally show selected options #646

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devnyxie
Copy link

@devnyxie devnyxie commented Mar 7, 2024

Transfer of @prnvbn work along with @MarvinJWendt changes.

@devnyxie devnyxie changed the title Update InteractiveMultiselectPrinter to optionally show selected optionsTransfer of @prnvbn work along with @MarvinJWendt changes. Update InteractiveMultiselectPrinter to optionally show selected options Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 80.88%. Comparing base (1a9d517) to head (fb46f6c).
Report is 1 commits behind head on master.

Files Patch % Lines
interactive_multiselect_printer.go 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   81.05%   80.88%   -0.17%     
==========================================
  Files          33       33              
  Lines        4176     4186      +10     
==========================================
+ Hits         3385     3386       +1     
- Misses        718      726       +8     
- Partials       73       74       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Error fixed: emptyStringTest: replace `len(p.fuzzySearchString) > 0` with `p.fuzzySearchString != ""` (gocritic)
Copy link

@CaneVoidNine CaneVoidNine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants