Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to open in new tab #617

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

prnvbn
Copy link

@prnvbn prnvbn commented Jan 21, 2024

Description

  • Updated the docs to open examples in a new tab. Personally, I find this more convenient as I refer to the examples and this prevents me opening the docs tab again and again. I hope you agree with this.
  • Also updated contributing.md. In some places, TemplatePrinter was TextPrinter

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02ac513) 81.66% compared to head (8874857) 81.66%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files          33       33           
  Lines        4139     4139           
=======================================
  Hits         3380     3380           
  Misses        695      695           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarvinJWendt
Copy link
Member

Hi, thanks for the PR! The links are generated here:

links = append(links, fmt.Sprintf(`<li><a href="https://github.com/pterm/pterm/tree/master/_examples/%s">%s</a></li>`, printer, printer))

You would have to change that, otherwise the CI would overwrite your change as soon as we merge it.

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment before (#617 (comment))

@MarvinJWendt MarvinJWendt added the waiting for response Waiting for author to respond label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Waiting for author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants