Fix duplicated multiselect #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`InteractiveSelectPrinter.Show()` always returns string and error. User can't get index of selected option from `Options` array. In some cases user need duplicated names. Current codebase will not return good response for duplicated options. Returning `selectedOption` attribute by another functions keep backward-compatibility and solve this problem. Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
In this test code will create a menu of a, b and c strings then concurrently press key down two times and enter. Then check `GetSelectedOption` return value with 2. Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
- Check selectedOption value. - Simulate human behavior and check result for normal usage. - Check conflict on simultaneous use of both functions of setting default option. Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
Signed-off-by: alireza <alirezaarzehgar82@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 82.23% 82.61% +0.38%
==========================================
Files 30 30
Lines 3501 3509 +8
==========================================
+ Hits 2879 2899 +20
+ Misses 564 558 -6
+ Partials 58 52 -6
|
|
Hi @alirezaarzehgar, sorry for the late reply, I was on vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Library can't handle duplicated option names cause it's design is based on checking option names not indexes. This PR change this behavior without breaking backward compatibility.
Scope
Related Issue
Fixes #535
To-Do Checklist