New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multiselect): option to change checkmarks #429
feat(multiselect): option to change checkmarks #429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 81.52% 86.10% +4.57%
==========================================
Files 29 29
Lines 2106 2108 +2
==========================================
+ Hits 1717 1815 +98
+ Misses 372 263 -109
- Partials 17 30 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, really appreciate it. Just some nitpicking stuff, otherwise it looks good 👍
…arks_in_interactice_multiselect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing 🎉 🚀
I have made some additional changes to enable changing the checkmarks via a custom theme. Should be pushed soon. |
Yes, I was thinking adding that myself. That's great!!! |
Description
Added the option to define the checkmarks in the interactive multiselect printer.
Also added some basic test cases.
Scope
Related Issue
Fixes #418
To-Do Checklist