Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiselect): option to change checkmarks #429

Conversation

KarolosLykos
Copy link
Contributor

Description

Added the option to define the checkmarks in the interactive multiselect printer.
Also added some basic test cases.

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #418

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #429 (2806031) into master (c1e924e) will increase coverage by 4.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   81.52%   86.10%   +4.57%     
==========================================
  Files          29       29              
  Lines        2106     2108       +2     
==========================================
+ Hits         1717     1815      +98     
+ Misses        372      263     -109     
- Partials       17       30      +13     
Impacted Files Coverage Δ
atoms.go 100.00% <ø> (ø)
interactive_multiselect_printer.go 54.44% <100.00%> (+54.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, really appreciate it. Just some nitpicking stuff, otherwise it looks good 👍

interactive_multiselect_printer.go Outdated Show resolved Hide resolved
interactive_multiselect_printer.go Outdated Show resolved Hide resolved
interactive_multiselect_printer.go Outdated Show resolved Hide resolved
interactive_multiselect_printer.go Outdated Show resolved Hide resolved
interactive_multiselect_printer_test.go Show resolved Hide resolved
Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🎉 🚀

@MarvinJWendt MarvinJWendt changed the title add: proposal option to change checkmarks in the intercactive multise… feat(multiselect): option to change checkmarks Jan 5, 2023
@MarvinJWendt MarvinJWendt merged commit 19c2c06 into pterm:master Jan 5, 2023
@github-actions github-actions bot added feature and removed feature labels Jan 5, 2023
@MarvinJWendt
Copy link
Member

MarvinJWendt commented Jan 5, 2023

I have made some additional changes to enable changing the checkmarks via a custom theme. Should be pushed soon.

@KarolosLykos
Copy link
Contributor Author

I have made some additional changes to enable changing the checkmarks via a custom theme. Should be pushed soon.

Yes, I was thinking adding that myself. That's great!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to change checkmarks in the interactive multiselect
2 participants