Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progressbar): Added option to set the MaxWidth of a progressbar #315

Conversation

MarvinJWendt
Copy link
Member

@MarvinJWendt MarvinJWendt commented Feb 14, 2022

Description

Add option to set the MaxWidth of the progressbar

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #314

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #315 (af0ab3a) into master (1f4d2c7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #315   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1443      1459   +16     
=========================================
+ Hits          1443      1459   +16     
Impacted Files Coverage Δ
progressbar_printer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4d2c7...af0ab3a. Read the comment docs.

@MarvinJWendt MarvinJWendt marked this pull request as ready for review February 17, 2022 01:02
@MarvinJWendt MarvinJWendt changed the title feat(progressbar): Add option to set the MaxWidth of the progressbar feat(progressbar): Added option to set the MaxWidth of the progressbar Feb 17, 2022
@github-actions github-actions bot added feature and removed feature labels Feb 17, 2022
@MarvinJWendt MarvinJWendt changed the title feat(progressbar): Added option to set the MaxWidth of the progressbar feat(progressbar): Added option to set the MaxWidth of a progressbar Feb 17, 2022
@github-actions github-actions bot added feature and removed feature labels Feb 17, 2022
@MarvinJWendt MarvinJWendt merged commit 590d29d into master Feb 17, 2022
@MarvinJWendt MarvinJWendt deleted the issue-314-Make_default_progressbar_smaller_and_add_option_for_full_width branch February 17, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make default progressbar smaller and add option for full width
1 participant