Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixed flaky tests on linux/macos #290

Merged
merged 2 commits into from Nov 5, 2021
Merged

ci: fixed flaky tests on linux/macos #290

merged 2 commits into from Nov 5, 2021

Conversation

TobiaszCudnik
Copy link
Contributor

Description

  • replaced stdout capture with an in-memory buffer
  • fixed non-windows platforms
  • possibly increased the speed of tests (1.650s)

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #289

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • N/A I updated the examples to fit with my changes
  • N/A I have added tests for my newly created methods

@MarvinJWendt MarvinJWendt changed the title Fixed flaky tests on linux/macos ci: fixed flaky tests on linux/macos Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #290 (a0f9ec5) into master (c0da86a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1306      1306           
=========================================
  Hits          1306      1306           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0da86a...a0f9ec5. Read the comment docs.

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🚀
Finally, we can run the CI in linux again 😉

@MarvinJWendt MarvinJWendt merged commit 7daebb5 into pterm:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests flaky on linux/macos
2 participants