Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better concurrency pattern for LivePrinters #439

Open
MarvinJWendt opened this issue Jan 7, 2023 · 0 comments · May be fixed by #447
Open

Better concurrency pattern for LivePrinters #439

MarvinJWendt opened this issue Jan 7, 2023 · 0 comments · May be fixed by #447
Labels
proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future

Comments

@MarvinJWendt
Copy link
Member

MarvinJWendt commented Jan 7, 2023 •
edited

Currently, the live printers do not adhere to a common concurrency pattern, which has resulted in thread safety issues such as those described in issue #391. In order to fix these issues, I suggest introducing a mutex to ensure the thread safety of the variables.

However, it is worth noting that this change may necessitate the migration of some methods to pointer methods, which could potentially be a breaking change. Further investigation will be required to determine the full extent of this impact.

This issue was previously identified in relation to the SpinnerPrinter in issue #423.
@MarvinJWendt MarvinJWendt added proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future labels Jan 7, 2023
This was referenced Jan 7, 2023
Closed
Open
@josh-pritchard josh-pritchard linked a pull request Jan 25, 2023 that will close this issue
Draft
@KarolosLykos KarolosLykos mentioned this issue Apr 7, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix most data race issues & enable in CI tests solo-io/pterm
1 participant
@MarvinJWendt