Spinner is not being removed from the terminal

[Wagnerbr90]

I'm facing a problem using the pterm in our CLI, sometimes the spinner is not being removed from the terminal, as you can see below ("Getting plan...").

I've noticed that when we set "spinner.Success() or spinner.Fail()", it should clear the line in the terminal, but sometimes it doesn't work, apparently

[MarvinJWendt]

Hi, this is the docs repo 😉
I'll move the issue to the main repo.

[MarvinJWendt]

Do you have any reproducible code example on that? I would tackle the issue, but I cannot reproduce it.

[Wagnerbr90]

We are just setting the spinner at start

spinner, _ = spn.GetDefaultSpinner(i18n.Translator.Translate("GettingApisAndPlanSpinner"), false)
// spn is from an import
// When things are done, we finish it...
spinner.Success()

As u can see above, most of the time it works, but sometimes it doesn't

[MarvinJWendt]

Could you please also share the configuration of the spinner (spn.GetDefaultSpinner)?

[Wagnerbr90]

Could you please also share the configuration of the spinner (spn.GetDefaultSpinner)?

func GetDefaultSpinner(message string, showFinalMessage bool) (*pterm.SpinnerPrinter, error) {
	spinner, err := pterm.DefaultSpinner.Start(message)
	if err != nil {
		return nil, err
	}

	spinner.SuccessPrinter = printer.NewPrefixPrinter("SUCCESS ", &pterm.ThemeDefault.SuccessMessageStyle)
	spinner.FailPrinter = printer.NewPrefixPrinter("ERROR   ", &pterm.ThemeDefault.ErrorMessageStyle)
	spinner.InfoPrinter = printer.NewPrefixPrinter("INFO    ", &pterm.ThemeDefault.DefaultText)
	spinner.WarningPrinter = printer.NewPrefixPrinter("WARNING ", &pterm.ThemeDefault.WarningMessageStyle)

	spinner.RemoveWhenDone = !showFinalMessage

	return spinner, nil
}

[MarvinJWendt]

I played around a little and I could replicate this issue very rarely.
This is related to a concurrency issue in the spinner, discovered in #423.

At the current time, it doesn't seem like an easy fix, as we would have to introduce a better concurrency pattern for all of our live printers (which might be overdue, looking at the current one).

I made a new issue with a proposal to change our concurrency pattern for all live printers in #439.