Remove type modifier decoding from Column object #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvarrazzo
force-pushed
the
refactor-typeinfo
branch
from
8628e88
to
31d9ec5
Compare
dlax
approved these changes
May 13, 2024
This changeset is enough to pass the current test suite, but probably it might require some cleanup. Close #450
Make sure that what displayed is the same displayed by postgres for all supported types.
dvarrazzo
force-pushed
the
refactor-typeinfo
branch
from
31d9ec5
to
862acac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type modifier decoding is implemented in the
Columnclass. The code had to know how to decode the fmod value according to different types, therefore it is a maze of ifs and cannot be extended if not changing the code.Move the parsing to the
TypeInfoobject, and within it to aTypeModifiersub-object. This way the code to decode the fmod is automatically dispatched according to the type. DifferentTypeModifiersubclasses can parse the different Postgres types that support modifiers.Close #450.