fix: lock the connection during a 'notifies()' call #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous implementation, it was possible to sneak an execute() while the generator is consumed. This gives the false impression that it's possible to use the connection while listening (see #756), which is false for reason better explored in #757. Therefore, lock the connection while listening to notifications. If someone wants to mix commands with listening on the same connection, they should do it collaboratively with an adequately short notifies() timeout.
dvarrazzo
force-pushed
the
blocking-notifies
branch
from
8766e29
to
a6da8e3
Compare
dlax
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous implementation, it was possible to sneak an execute() while the generator is consumed. This gives the false impression that it's possible to use the connection while listening (see #756), which is false for reason better explored in #757.
Therefore, lock the connection while listening to notifications. If someone wants to mix commands with listening on the same connection, they should do it collaboratively with an adequately short notifies() timeout.