None returning dumper #642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvarrazzo
force-pushed
the
none-returning-dumper
branch
from
2952d85
to
5ac82ca
Compare
dvarrazzo
force-pushed
the
none-returning-dumper
branch
from
5ac82ca
to
ae569f2
Compare
dvarrazzo
force-pushed
the
none-returning-dumper
branch
2 times, most recently
from
6b06066
to
ea960ef
Compare
We missed to reset the number of chars to escape at every field. As a consequence, we end up resizing and scanning all the fields after the first one requiring an escape and allocating a bit more memory than needed.
dvarrazzo
force-pushed
the
none-returning-dumper
branch
from
ea960ef
to
dccfee0
Compare
These are only the changes suggested by Mypy; no test added to verify that the code paths actually work. Only Python test fixed, no C yet.
Even if these classes never return None, this allows to create subclasses returning None without making Mypy unhappy. Similarly, annotate quote() methods as returning Buffer to allow subclasses to return other types.
dvarrazzo
force-pushed
the
none-returning-dumper
branch
from
dccfee0
to
0c8b2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch was created a few months ago, now it's probably stale and needs to be rebased on master. There might be some types missing (numpy types were probably added afterwards) needing the same treatment.
Close #377