Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move modifier parsing functions to TypeInfo #450

Closed
dvarrazzo opened this issue Dec 6, 2022 · 1 comment · Fixed by #811
Closed

Refactor: move modifier parsing functions to TypeInfo #450

dvarrazzo opened this issue Dec 6, 2022 · 1 comment · Fixed by #811
Labels
enhancement New feature or request
Milestone
3.2

Comments

@dvarrazzo
Copy link
Member

Currently, the Column object contains convoluted ad-hoc code to be able to parse the type modifier value into something to display. See #449 for some details.

Create equivalent typmodout functions and attach them to builtin data types, giving the possibility to extension types to use theirs as well.
@dvarrazzo dvarrazzo added the enhancement New feature or request label Dec 6, 2022
@dvarrazzo dvarrazzo added this to the 3.2 milestone Dec 6, 2022
@dvarrazzo
Copy link
Member Author

For better details: whenever types are used for branching, in the Column code, what we need to do instead is to look up for that type in the registry and to use a method, which loaders may override, where to implement the type-specific code.

dvarrazzo added a commit that referenced this issue May 9, 2024
@dvarrazzo
refactor: dispatch type modifier parsing to type-specific objects
e214d74 
This changeset is enough to pass the current test suite, but probably it
might require some cleanup.

Close #450
dvarrazzo added a commit that referenced this issue May 9, 2024
@dvarrazzo
refactor: dispatch type modifier parsing to type-specific objects
67964b6 
This changeset is enough to pass the current test suite, but probably it
might require some cleanup.

Close #450
@dvarrazzo dvarrazzo mentioned this issue May 9, 2024
Merged
dvarrazzo added a commit that referenced this issue May 15, 2024
@dvarrazzo
refactor: dispatch type modifier parsing to type-specific objects
a90a20e 
This changeset is enough to pass the current test suite, but probably it
might require some cleanup.

Close #450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Remove type modifier decoding from Column object psycopg/psycopg
1 participant
@dvarrazzo