Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify sphinx dirhtml builder, use references instead of absolutes #6612

Merged
merged 4 commits into from
Dec 23, 2023

Conversation

miketheman
Copy link
Member

With the requirement of a configuration file, the default builder of dirhtml that RTD used to use is no longer specified. This leads to URLs ending in .html now, which
breaks other exisitng references.

Refs: #6603
Refs: https://docs.readthedocs.io/en/stable/config-file/v2.html#sphinx-builder
Refs: https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.dirhtml.DirectoryHTMLBuilder

With the requirement of a configuration file, the default builder
of `dirhtml` that RTD used to use is no longer specified.
This leads to URLs ending in `.html` now, which
breaks other exisitng references.

Refs: psf#6603
Refs: https://docs.readthedocs.io/en/stable/config-file/v2.html#sphinx-builder
Refs: https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.dirhtml.DirectoryHTMLBuilder

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
Copy link
Member Author

Probably should revert #6604 as well

@sigmavirus24
Copy link
Contributor

Please do include a revert of that PR in here. I didn't get a chance to object to it

This reverts commit 1396eb6, reversing
changes made to e4c821a.
@miketheman
Copy link
Member Author

Revert added

Any development links will now refer back to the generated docs.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman changed the title docs: specify sphinx dirhtml builder docs: specify sphinx dirhtml builder, use references instead of absolutes Dec 23, 2023
@miketheman
Copy link
Member Author

Added references instead of absolutes, so these shouldn't ever need to be changed despite the builder chosen.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Copy link
Contributor

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sigmavirus24 sigmavirus24 merged commit 72eccc8 into psf:main Dec 23, 2023
8 of 29 checks passed
@miketheman miketheman deleted the fix-docs-urls branch December 23, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants