WIP: Make Brotli support enabled by default, if appropriate urllib3 version is available #5554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress - I have to make sure that the tests are actually running, not skipped every time 馃槄 but I would like to get feedback if the direction is right.
I had to update some deps to make the tests pass after a lot of packages being updated after I added
brotli
to dev-packages. But I assume that this should be done anyway. Especially as there were discrepancies in the versions - f.e.pytest
version insetup.py
commit message declared v. 4 compatibility while the version inPipenv
was set to be at most v. 3.10.1.Speaking of dependencies I have a doubt how to declare required urllib3 version. Technically the first with brotli support is 1.25.1, but this is a version not supported by Requests... Should I update all the references to require urllib3 >= 1.25.2 then instead of >= 1.25.1?