Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt requests' version range check to release 5.0.0 of chardet #6183

Closed
christian-monch opened this issue Jun 29, 2022 · 2 comments
Closed

Comments

@christian-monch
Copy link

Summary

chardet version 5.0.0 was released on pypi on 25th of June 2022. If this version is picked up by your dependencies, requests version 2.28.0 will issue the following warning:

.../lib/python3.9/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.8) or chardet (5.0.0)/charset_normalizer (2.0.4) doesn't match a supported version!"

I am not sure whether version 5.0.0 of chardet is compatible with requests. According to the documentation, requests supports chardet version 4. It would be good to verify the compatibility with chardet version 5 and adapt the version range check accordingly

Reproduction Steps

Install the latest version of chardet:

$ pip install --upgrade chardet

Import requests in python to trigger the warning:

import requests

System Information

$ python -m requests.help
{
  "chardet": {
    "version": "5.0.0"
  },
  "charset_normalizer": {
    "version": "2.0.12"
  },
  "cryptography": {
    "version": ""
  },
  "idna": {
    "version": "3.3"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.9.13"
  },
  "platform": {
    "release": "5.3.18-150300.59.76-default",
    "system": "Linux"
  },
  "pyOpenSSL": {
    "openssl_version": "",
    "version": null
  },
  "requests": {
    "version": "2.27.1"
  },
  "system_ssl": {
    "version": "1010104f"
  },
  "urllib3": {
    "version": "1.26.9"
  },
  "using_charset_normalizer": false,
  "using_pyopenssl": false
}
@sethmlarson
Copy link
Member

Closing as a duplicate of #6177. Please search for open and closed issues before opening a new issue.

@christian-monch
Copy link
Author

Thx, searched for an issue, but did not find it. Will search more intensely next time! ;-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants