Fix test errors caused by updated chardet v5 release #6777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit specifies that a chardet version larger than 3.0.4 and smaller than 5.0.0 is required. The reason for the upper limit is that "requests" does only support chardet version 4.
|
Merging this since it just changes a dependency definition and seems to fix the recently appearing test problem |
|
Cherry pick commit 0c88872 to your branch to get the fix without rebasing |
was issue discovered/fixed/filed in requests on this? |
|
Not yet, will do that |
|
I did not find an existing issue in Filed a new issue psf/requests#6183 |
|
馃殌 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6776
This PR limits the allowed
chardetversion to <5.0.0, becauserequestsdoes only supportchardetup to version 4, and version 5.0.0. was released on pypi on 25th of June 2022Changelog
馃彔 Internal
requests-dependencies