Fix extract_zipped_paths infinite loop when provided invalid unc path #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
reviewed
Jul 6, 2021
| @@ -245,6 +245,9 @@ def extract_zipped_paths(path): | |||
| archive, member = os.path.split(path) | |||
| while archive and not os.path.exists(archive): | |||
| archive, prefix = os.path.split(archive) | |||
| if not prefix: | |||
There was a problem hiding this comment.
This explains why, but the code isn't clear as to what's happening or why this fixes the infinite loop. For example, a far superior comment might be:
# If we don't check for an empty prefix after the split (in other words, archive = / before and after the split), we _can_ end up in an infinite loop on a rare corner case affecting a small number of users
This comment explains the conditions, why we care (it affects users), and the risk to making a change (if we break this again, we may not find out about it quickly)
There was a problem hiding this comment.
Thanks for the feedback, I've updated the comment.
tl-hbk
force-pushed
the
fix_extract_zipped_paths
branch
from
ad17472
to
3d6c95b
Compare
sigmavirus24
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5850