Fix extract_zipped_paths infinite loop when provided invalid unc path

psf · Jun 30, 2021 · ad17472 · ad17472
1 parent 1466ad7
commit ad17472
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/requests/utils.py b/requests/utils.py
@@ -245,6 +245,9 @@ def extract_zipped_paths(path):
     archive, member = os.path.split(path)
     while archive and not os.path.exists(archive):
         archive, prefix = os.path.split(archive)
+        if not prefix:
+            # Needed to prevent infinite looping when provided invalid UNC path
+            break
         member = '/'.join([prefix, member])
 
     if not zipfile.is_zipfile(archive):

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -285,6 +285,10 @@ def test_zipped_paths_extracted(self, tmpdir):
         assert os.path.exists(extracted_path)
         assert filecmp.cmp(extracted_path, __file__)
 
+    def test_invalid_unc_path(self):
+        path = r"\\localhost\invalid\location"
+        assert extract_zipped_paths(path) == path
+
 
 class TestContentEncodingDetection: