Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert all headers to bytes before invoking urllib3/httplib #3573

Closed
stefanfoulis opened this issue Sep 14, 2016 · 3 comments
Closed

convert all headers to bytes before invoking urllib3/httplib #3573

stefanfoulis opened this issue Sep 14, 2016 · 3 comments

Comments

@stefanfoulis
Copy link

related to #3177 and urllib3/urllib3#855

It's really easy to get this wrong. See tedder/requests-aws4auth#24 for an example.
@stefanfoulis stefanfoulis mentioned this issue Sep 14, 2016
Closed
@Lukasa
Copy link
Member

Lukasa commented Sep 15, 2016

There is no requirement for us to pass urllib3 bytes. urllib3's interface has always allowed native strings on the platform, which includes unicode on Python 3. The specific error you're looking at is one that we have already fixed in urllib3, so a fix will be coming down the pipe in the next few months. =)

@Lukasa Lukasa closed this as completed Sep 15, 2016
@stefanfoulis
Copy link
Author

@Lukasa what is the change in urllib3 that will solve this issue?

@Lukasa
Copy link
Member

Lukasa commented Sep 15, 2016

It's urllib3/urllib3#719

@jminuscula jminuscula mentioned this issue Jul 27, 2017
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanfoulis @Lukasa