Split the TRAILING_COMMA feature #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 979
💛 - Coveralls |
We no longer add the trailing comma in 3.5.
18 tasks
|
Hey all, do you know when can we expect to have this PR merged and released? Issue #759 is currently blocking us from migrating to Black, as our project supports multiple Python version including Python 3.5. Thanks! |
zsol
approved these changes
Mar 25, 2019
|
@JelleZijlstra @zsol Thanks for taking care of this PR! Do you know when can we expect a new release? |
|
@maarcingebala sometime in April we're going to make the first stable release. |
|
Thanks for the info! |
lirsacc
added a commit
to lirsacc/py-gql
that referenced
this pull request
Apr 4, 2019
Until this black PR (psf/black#763) is released the formatting adds spurious trailing commas on Python 3.5 which creates a syntax error.
lirsacc
added a commit
to lirsacc/py-gql
that referenced
this pull request
Apr 4, 2019
Until this black PR (psf/black#763) is released the formatting adds spurious trailing commas on Python 3.5 which creates a syntax error.
lirsacc
added a commit
to lirsacc/py-gql
that referenced
this pull request
Apr 4, 2019
Until this black PR (psf/black#763) is released the formatting adds spurious trailing commas on Python 3.5 which creates a syntax error.
lirsacc
added a commit
to lirsacc/py-gql
that referenced
this pull request
Apr 4, 2019
Until this black PR (psf/black#763) is released the formatting adds spurious trailing commas on Python 3.5 which creates a syntax error.
|
Any updates on the stable release? This bug blocks our team for migrating to Black too. |
1 task
bdraco
added a commit
to bdraco/python-zeroconf
that referenced
this pull request
May 27, 2021
- The issue that prevented black from being used on this block was resolved in psf/black#763
anthonymedinawork
added a commit
to anthonymedinawork/py-gql
that referenced
this pull request
Jan 24, 2024
Until this black PR (psf/black#763) is released the formatting adds spurious trailing commas on Python 3.5 which creates a syntax error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
f(*x,)became legal in 3.5, butdef f(*x,):only became legal in 3.6. Therefore, use two separate Features.Fixes #759.