Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fallback to using a ThreadPoolExecutor #533

Closed
wants to merge 1 commit into from
Closed

Added a fallback to using a ThreadPoolExecutor #533

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2018

This enables devices lacking a hardware semaphore implementation such as some Android Devices (looking at the OnePlus3T here!) to still use black.

Fixes #524

@ghost ghost mentioned this pull request Sep 26, 2018
@coveralls
Copy link

coveralls commented Sep 26, 2018

Pull Request Test Coverage Report for Build 748

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.825%

Files with Coverage Reduction New Missed Lines %
black.py 1 65.33%
Totals Coverage Status
Change from base Build 743: -0.03%
Covered Lines: 1974
Relevant Lines: 2060

💛 - Coveralls

@ambv
Copy link
Collaborator

ambv commented Sep 26, 2018

Thanks for testing that this fixes the issue for you. This is important to fix but I think we'll go with a "SerialExecutor" instead as described in #524.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants