(🎁) Remove redundant parenthesis in subscript operations #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
force-pushed
the
feat/parens_in_getitem
branch
from
950ef20
to
5901e52
Compare
|
diff-shades results comparing this PR (9e5a1e6) to main (27c05e1). The full diff is available in the logs under the "Generate HTML diff report" step. |
CHANGES.md
Outdated
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| - Implicitly concatenated strings used as function args are no longer wrapped inside | |||
| parentheses (#3640) | |||
| - Redundant parenthesis are removed from `__getitem__`/`__setitem__` calls (#3680) | |||
There was a problem hiding this comment.
Suggested change
| - Redundant parenthesis are removed from `__getitem__`/`__setitem__` calls (#3680) | |
| - Redundant parentheses are removed from subscript operations (#3680) |
| ) | ||
| or ( | ||
| is_walrus_assignment(node.children[1]) | ||
| # This is only supported in py310 and up |
There was a problem hiding this comment.
We should use black.mode.supports_feature here.
| x[(1, 2)] = 1 | ||
| x[1, 2] = 1 | ||
| x[(1, 2)] = 1 | ||
| x[(1, 2),] = 1 |
There was a problem hiding this comment.
Add some test cases that use del x[(1)] and similar, just because it's different in the grammar
KotlinIsland
changed the title
__getitem__ calls
KotlinIsland
force-pushed
the
feat/parens_in_getitem
branch
from
25d98d5
to
b56e84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getitem/indexing operator #3679Description
Okay, so basically I think this is a based feature because of the confusing nature of the implicit tupleification of getitem.
(Also it will help with KotlinIsland/basedmypy#418)
Checklist - did you ... know ❓
CHANGES.mdif necessary?I'm not familiar with this codebase sorry, all feedback is welcome!