Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail lint CI if the PR doesn't target main #3477

Merged
merged 2 commits into from Dec 31, 2022
Merged

Fail lint CI if the PR doesn't target main #3477

merged 2 commits into from Dec 31, 2022

Conversation

ichard26
Copy link
Collaborator

Description

Let's skip the check if we're running on a fork just in case someone opens a PR against a branch on said fork as part of a PR review upstream.

Example run: ichard26#60

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary? -> n/a
  • Add / update tests if necessary? -> n/a
  • Add new / update outdated documentation? -> n/a

@ichard26 ichard26 added skip news Pull requests that don't need a changelog entry. C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Dec 31, 2022
@ichard26
Fail lint CI if the PR doesn't target main
f552396 
Let's skip the check if we're running on a fork just in case someone
opens a PR against a branch on said fork as part of a PR review
upstream.
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (35e1928) to main (4e3303f).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 37542e6 into psf:main Dec 31, 2022
@calumy
Copy link

calumy commented Dec 31, 2022

Close #3379?

@ichard26 ichard26 deleted the fail-if-base-ref-is-not-main branch December 31, 2022 19:02
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
@ichard26 @hugovk
Fail lint CI if the PR doesn't target main (psf#3477)
61d24bc 
Let's skip the check if we're running on a fork just in case someone
opens a PR against a branch on said fork as part of a PR review
upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ichard26 @calumy @JelleZijlstra