Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in return annotation with walrus #3422

Closed
wants to merge 3 commits into from
Closed

Fix crash in return annotation with walrus #3422

wants to merge 3 commits into from

Conversation

JelleZijlstra
Copy link
Collaborator

Fixes #3419

Description

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

JelleZijlstra
JelleZijlstra commented Dec 10, 2022
View reviewed changes
tests/test_format.py Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra mentioned this pull request Dec 10, 2022
Merged
@JelleZijlstra
Copy link
Collaborator Author

Closing in favor of #3423.

@JelleZijlstra JelleZijlstra deleted the walrusparens branch December 10, 2022 18:20
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (41994d0) to main (96e62c5).

What is this? | Workflow run | diff-shades documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview style incorrectly removes parens from walrus in annotation
1 participant
@JelleZijlstra