Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal magic commas not being force expanded #3377

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix internal magic commas not being force expanded #3377

wants to merge 4 commits into from

Commits on Nov 9, 2022

  1. Create failing test case 

    Copied the examples from the bug report and added an additional test case with the failing behavior multiple times in the same expression.
    @KindaOK
    KindaOK committed Nov 9, 2022
    Copy the full SHA
    7b2c2ca View commit details
    Browse the repository at this point in the history

  2. Correct quote type in test case 

    Black always uses double quotes. Test would also fail on this, but that's not the reason the test is failing to begin with.
    @KindaOK
    KindaOK committed Nov 9, 2022
    Copy the full SHA
    8429ebc View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Fix another test bug 

    Correct output was missing a parentheses group in the original.
    @KindaOK
    KindaOK committed Nov 16, 2022
    Copy the full SHA
    6079db6 View commit details
    Browse the repository at this point in the history

  2. Move omit yield to end of generator 

    Fix `omit` generator exiting early after seeing two consecutive non-empty bracket pairs before seeing a magic comma. This does cause a regression with `trailing_comma_optional_parens2` and it still does not fix lines with multiple magic commas.
    @KindaOK
    KindaOK committed Nov 16, 2022
    Copy the full SHA
    48042ee View commit details
    Browse the repository at this point in the history