Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle trailing commas that are inside a line's leading non-nested parens #3370

Merged
merged 18 commits into from Nov 9, 2022
Merged

Correctly handle trailing commas that are inside a line's leading non-nested parens #3370

merged 18 commits into from Nov 9, 2022

Commits on Nov 1, 2022

  1. Initial implementation to handle trailing commas in leading parts.

    @yilei
    yilei committed Nov 1, 2022
    Copy the full SHA
    8e2cc91 View commit details
    Browse the repository at this point in the history

  2. Add changelogs, and format ourselves.

    @yilei
    yilei committed Nov 1, 2022
    Copy the full SHA
    3908d86 View commit details
    Browse the repository at this point in the history

  3. Make sure skip magic trailing comma still works for things on the lef… 

    …t hand side or leading non-nested parens.
    @yilei
    yilei committed Nov 1, 2022
    Copy the full SHA
    2213012 View commit details
    Browse the repository at this point in the history

  4. Fix two bugs and add more tests. 

    1. The change wasn't guarded by preview mode.
2. Checking trailing commas in inner parens should only be done on the `head` component after bracket split.
    @yilei
    yilei committed Nov 1, 2022
    Copy the full SHA
    6a14f81 View commit details
    Browse the repository at this point in the history

  5. Switch to importing members.

    @yilei
    yilei committed Nov 1, 2022
    Copy the full SHA
    c38bf9a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into trailing_comma

    @yilei
    yilei committed Nov 1, 2022
    Copy the full SHA
    5253b0a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. WIP: fix the bracket tracker usage.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    0ae0c5c View commit details
    Browse the repository at this point in the history

  2. Clean up implementation.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    f53c2b9 View commit details
    Browse the repository at this point in the history

  3. Undo the BracketMatchError change; simply implementation.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    0892ca1 View commit details
    Browse the repository at this point in the history

  4. Fix lint.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    227c5f4 View commit details
    Browse the repository at this point in the history

  5. Fix an infinite recursion error.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    b334d77 View commit details
    Browse the repository at this point in the history

  6. Fix lint errors.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    dec8076 View commit details
    Browse the repository at this point in the history

  7. Extract a get_leaves_inside_matching_brackets function.

    @yilei
    yilei committed Nov 2, 2022
    Copy the full SHA
    d122d78 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Use is for comparing enums. 

    Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
    @yilei @JelleZijlstra
    yilei and JelleZijlstra committed Nov 8, 2022
    Copy the full SHA
    0909f3f View commit details
    Browse the repository at this point in the history

  2. Use is for comparing enums. 

    Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
    @yilei @JelleZijlstra
    yilei and JelleZijlstra committed Nov 8, 2022
    Copy the full SHA
    b59190b View commit details
    Browse the repository at this point in the history

  3. Use is for comparing enums. 

    Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
    @yilei @JelleZijlstra
    yilei and JelleZijlstra committed Nov 8, 2022
    Copy the full SHA
    0252a36 View commit details
    Browse the repository at this point in the history

  4. Remove commented out code.

    @yilei
    yilei committed Nov 8, 2022
    Copy the full SHA
    2307a95 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into trailing_comma

    @yilei
    yilei committed Nov 8, 2022
    Copy the full SHA
    6819dfc View commit details
    Browse the repository at this point in the history