Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an infinite loop when using #fmt: on/off in the middle of an expression or code block #3158

Merged
merged 9 commits into from Jul 20, 2022
Merged

Fix an infinite loop when using #fmt: on/off in the middle of an expression or code block #3158

merged 9 commits into from Jul 20, 2022
+47 −1

Commits on Jul 6, 2022

  1. Fix an infinite loop when handling # fmt: on/off.

    @yilei
    yilei committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    b420d19 View commit details
    Browse the repository at this point in the history

  2. Update CHANGES.md

    @yilei
    yilei committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    3a32173 View commit details
    Browse the repository at this point in the history

  3. Add more test cases from other reported issues.

    @yilei
    yilei committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    f09195e View commit details
    Browse the repository at this point in the history

  4. Update CHANGES.md for expanded scope.

    @yilei
    yilei committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    6bca8a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Update CHANGES.md 

    Co-authored-by: Richard Si <63936253+ichard26@users.noreply.github.com>
    @yilei @ichard26
    yilei and ichard26 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    676bb73 View commit details
    Browse the repository at this point in the history

  2. Instead of include all children, return early when encountering a Lea… 

    …f node with `# fmt: on`.

Also special case as a hack to include closing brackets. The alternative is to fail the formatting.
    @yilei
    yilei committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3e554ed View commit details
    Browse the repository at this point in the history

  3. Fix the link to the regression test's issue number.

    @yilei
    yilei committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    73b9712 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Merge branch 'main' into fmthang

    @JelleZijlstra
    JelleZijlstra committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6856d73 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fmthang

    @ichard26
    ichard26 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    051772e View commit details
    Browse the repository at this point in the history