Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return annotation brackets #2990

Merged
merged 12 commits into from Apr 9, 2022
Merged

Return annotation brackets #2990

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d083472
Optional brackets around return anotations
jpy-git Apr 2, 2022
040762b
Merge branch 'main' into return_annotation_brackets
jpy-git Apr 2, 2022
d3ae3c2
Ready to test
jpy-git Apr 2, 2022
ed6d374
whoops missed a yield from
jpy-git Apr 2, 2022
6291b5c
Merge branch 'main' into return_annotation_brackets
jpy-git Apr 2, 2022
33a1fd6
Update CHANGES.md
jpy-git Apr 2, 2022
81cadaa
Crazy brackets!
jpy-git Apr 2, 2022
cc2e032
Merge branch 'main' into return_annotation_brackets
jpy-git Apr 3, 2022
86bbff0
Fix previous main merge and extra unit tests for commas
jpy-git Apr 3, 2022
c3a6505
Magic trailing comma example for completeness
jpy-git Apr 3, 2022
fc48804
Turns out this also fixes #2699 :)
jpy-git Apr 6, 2022
20649d1
Merge branch 'main' into return_annotation_brackets
jpy-git Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 37 additions & 0 deletions tests/data/return_annotation_brackets.py
View file
Open in desktop
Expand Up @@ -53,6 +53,27 @@ def foo(a: int, b: int, c: int,) -> intsdfsafafafdfdsasdfsfsdfasdfafdsafdfdsfasd
def foo(a: int, b: int, c: int,) -> int:
return 2

# Deeply nested brackets
# with *interesting* spacing
jpy-git marked this conversation as resolved.
Show resolved Hide resolved
def double(a: int) -> (((((int))))):
return 2*a

def double(a: int) -> (
( (
((int)
)
)
)
):
return 2*a

def foo() -> (
( (
intsdfsafafafdfdsasdfsfsdfasdfafdsafdfdsfasdskdsdsfdsafdsafsdfdasfffsfdsfdsafafhdskfhdsfjdslkfdlfsdkjhsdfjkdshfkljds
)
)):
return 2

# output
# Control
def double(a: int) -> int:
Expand Down Expand Up @@ -132,3 +153,19 @@ def foo(
c: int,
) -> int:
return 2


# Deeply nested brackets
# with *interesting* spacing
def double(a: int) -> int:
return 2 * a


def double(a: int) -> int:
return 2 * a


def foo() -> (
intsdfsafafafdfdsasdfsfsdfasdfafdsafdfdsfasdskdsdsfdsafdsafsdfdasfffsfdsfdsafafhdskfhdsfjdslkfdlfsdkjhsdfjkdshfkljds
):
return 2