Remove usage of _unicodefun module from dependency: 'click' #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule has been removed from this library.
|
Thanks, closing in favor of #2966. |
|
We still need this so 3.6 still works even if LANG is misconfigured for unicode. |
|
Right on! Glad there was an easy fix. Thanks for being on top of it! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
_unicodefunmodule has been removed from the click library.In addition, it is also not actively being used in the
blackrepository.See reports here:
• pallets/click#2225
• pallets/click#2198
Checklist - did you ...