Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farewell black-primer, it was nice knowing you #2924

Merged
merged 1 commit into from Mar 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
Expand Up @@ -50,6 +50,8 @@

- On Python 3.11 and newer, use the standard library's `tomllib` instead of `tomli`
(#2903)
- `black-primer`, the deprecated internal devtool, has been removed and copied to a
[separate repository](https://github.com/cooperlees/black-primer) (#2924)

### Parser

Expand Down
6 changes: 0 additions & 6 deletions docs/contributing/gauging_changes.md
Expand Up @@ -7,12 +7,6 @@ It's recommended you evaluate the quantifiable changes your _Black_ formatting
modification causes before submitting a PR. Think about if the change seems disruptive
enough to cause frustration to projects that are already "black formatted".

## black-primer

`black-primer` is an obsolete tool (now replaced with `diff-shades`) that was used to
gauge the impact of changes in _Black_ on open-source code. It is no longer used
internally and will be removed from the _Black_ repository in the future.

## diff-shades

diff-shades is a tool that runs _Black_ across a list of Git cloneable OSS projects
Expand Down
8 changes: 0 additions & 8 deletions mypy.ini
Expand Up @@ -39,11 +39,3 @@ cache_dir=/dev/null
# The following is because of `patch_click()`. Remove when
# we drop Python 3.6 support.
warn_unused_ignores=False

[mypy-black_primer.*]
# Until we're not supporting 3.6 primer needs this
disallow_any_generics=False

[mypy-tests.test_primer]
# Until we're not supporting 3.6 primer needs this
disallow_any_generics=False
4 changes: 1 addition & 3 deletions setup.py
Expand Up @@ -58,7 +58,7 @@ def find_python_files(base: Path) -> List[Path]:
"black/__main__.py",
]
discovered = []
# black-primer and blackd have no good reason to be compiled.
# There's no good reason for blackd to be compiled.
discovered.extend(find_python_files(src / "black"))
discovered.extend(find_python_files(src / "blib2to3"))
mypyc_targets = [
Expand Down Expand Up @@ -92,7 +92,6 @@ def find_python_files(base: Path) -> List[Path]:
package_data={
"blib2to3": ["*.txt"],
"black": ["py.typed"],
"black_primer": ["primer.json"],
},
python_requires=">=3.6.2",
zip_safe=False,
Expand Down Expand Up @@ -132,7 +131,6 @@ def find_python_files(base: Path) -> List[Path]:
"console_scripts": [
"black=black:patched_main",
"blackd=blackd:patched_main [d]",
"black-primer=black_primer.cli:main",
]
},
)
Empty file removed src/black_primer/__init__.py
Empty file.
195 changes: 0 additions & 195 deletions src/black_primer/cli.py

This file was deleted.