New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly run ourselves twice #2807
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ff9c654
properly run ourselves twice
JelleZijlstra 5a3ca0d
prettier
JelleZijlstra a4242a9
fix assert_stable
JelleZijlstra 010c6c6
update tests
JelleZijlstra ea1f684
fix primer.json
JelleZijlstra f8207ec
channels wants changes
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,15 @@ | ||
if e1234123412341234.winerror not in (_winapi.ERROR_SEM_TIMEOUT, | ||
_winapi.ERROR_PIPE_BUSY) or _check_timeout(t): | ||
pass | ||
|
||
# output | ||
|
||
if ( | ||
e1234123412341234.winerror | ||
not in ( | ||
_winapi.ERROR_SEM_TIMEOUT, | ||
_winapi.ERROR_PIPE_BUSY, | ||
) | ||
or _check_timeout(t) | ||
): | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,17 @@ | ||
if (e123456.get_tk_patchlevel() >= (8, 6, 0, 'final') or | ||
(8, 5, 8) <= get_tk_patchlevel() < (8, 6)): | ||
pass | ||
pass | ||
|
||
# output | ||
|
||
if ( | ||
e123456.get_tk_patchlevel() >= (8, 6, 0, "final") | ||
or ( | ||
8, | ||
5, | ||
8, | ||
) | ||
<= get_tk_patchlevel() | ||
< (8, 6) | ||
): | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does assert_stable really need to call
format_str
now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we could call
_format_str_once
instead, but I like the idea of that being a private function that nobody else should call.We still need to call some variant of format_str here in case it's still not stable after the second pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already a bit of stretch but I was concerned about
assert_stable
hiding a stability bug chain of two (one in the main secondary format pass, and then the first under assert_stable's format_str) . I suppose it doesn't matter at this point though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it might hide a cycle, where we move back and forth between two versions deterministically.