Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blib2to3 can raise TokenError and IndentationError too #2671

Merged
merged 1 commit into from Dec 5, 2021
Merged

blib2to3 can raise TokenError and IndentationError too #2671

merged 1 commit into from Dec 5, 2021

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Dec 5, 2021

Fix the regression of GH-2317 caused by GH-2668. I explicitly made this PR from my fork of psf/black so the workflows are triggered from the PR event which should catch post-merge issues.

  • Add a CHANGELOG entry if necessary? -> the regression hasn't been released yet
  • Add / update tests if necessary? -> CI will test this
  • Add new / update outdated documentation? -> n/a

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Dec 5, 2021
JelleZijlstra
JelleZijlstra approved these changes Dec 5, 2021
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra JelleZijlstra merged commit d9eee31 into psf:main Dec 5, 2021
@ichard26 ichard26 deleted the fix-up-main branch July 28, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ichard26 @JelleZijlstra