Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line generation for match match: / case case: #2661

Merged
merged 1 commit into from Nov 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
Expand Up @@ -10,6 +10,8 @@
- Fixed Python 3.10 support on platforms without ProcessPoolExecutor (#2631)
- Fixed `match` statements with open sequence subjects, like `match a, b:` or
`match a, *b:` (#2639) (#2659)
- Fixed `match`/`case` statements that contain `match`/`case` soft keywords multiple
times, like `match re.match()` (#2661)
- Fixed assignment to environment variables in Jupyter Notebooks (#2642)
- Add `flake8-simplify` and `flake8-comprehensions` plugins (#2653)

Expand Down
14 changes: 11 additions & 3 deletions src/black/linegen.py
Expand Up @@ -127,7 +127,7 @@ def visit_stmt(
"""Visit a statement.

This implementation is shared for `if`, `while`, `for`, `try`, `except`,
`def`, `with`, `class`, `assert`, `match`, `case` and assignments.
`def`, `with`, `class`, `assert`, and assignments.

The relevant Python language `keywords` for a given statement will be
NAME leaves within it. This methods puts those on a separate line.
Expand All @@ -142,6 +142,14 @@ def visit_stmt(

yield from self.visit(child)

def visit_match_case(self, node: Node) -> Iterator[Line]:
"""Visit either a match or case statement."""
normalize_invisible_parens(node, parens_after=set())

yield from self.line()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is the correct solution; it originates from the assumptions that for each match_statement/case_statement node, there will be only one valid match/case keyword for the context. So we simply yield a line; and for all following encounters of child nodes, we process them as usual.

for child in node.children:
yield from self.visit(child)

def visit_suite(self, node: Node) -> Iterator[Line]:
"""Visit a suite."""
if self.mode.is_pyi and is_stub_suite(node):
Expand Down Expand Up @@ -294,8 +302,8 @@ def __post_init__(self) -> None:
self.visit_decorated = self.visit_decorators

# PEP 634
self.visit_match_stmt = partial(v, keywords={"match"}, parens=Ø)
self.visit_case_block = partial(v, keywords={"case"}, parens=Ø)
self.visit_match_stmt = self.visit_match_case
self.visit_case_block = self.visit_match_case


def transform_line(
Expand Down
35 changes: 31 additions & 4 deletions tests/data/pattern_matching_extras.py
Expand Up @@ -23,10 +23,10 @@

def func(match: case, case: match) -> case:
match Something():
case another:
...
case func(match, case):
...
case another:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed some syntax errors in this file (e.g a name pattern can't be followed by anything else) to ensure everything is also parsable by the python parser.

...


match maybe, multiple:
Expand All @@ -47,6 +47,33 @@ def func(match: case, case: match) -> case:

match a, *b, c:
case [*_]:
return "seq"
assert "seq" == _
case {}:
return "map"
assert "map" == b


match match(
case,
match(
match, case, match, looooooooooooooooooooooooooooooooooooong, match, case, match
),
case,
):
case case(
match=case,
case=re.match(
loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong
),
):
pass

case [a as match]:
pass

case case:
pass


match match:
case case:
pass