Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cfg to ini for text highlighting #2632

Merged
merged 1 commit into from Nov 21, 2021
Merged

Change cfg to ini for text highlighting #2632

merged 1 commit into from Nov 21, 2021

Conversation

Ttibsi
Copy link
Contributor

@Ttibsi Ttibsi commented Nov 20, 2021

No description provided.

cooperlees
cooperlees approved these changes Nov 20, 2021
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this should look better / easier to parse. Thanks.

@cooperlees cooperlees added the skip news Pull requests that don't need a changelog entry. label Nov 20, 2021
@onerandomusername
Copy link
Contributor

Curious, but what about toml?

@Ttibsi
Copy link
Contributor Author

Ttibsi commented Nov 21, 2021

There was a mix of ini and toml throughout the document - I'm not sure which the devs/maintainers would prefer, but they're free to change it if preferred

@JelleZijlstra
Copy link
Collaborator

These aren't actually toml files. Thanks for your contribution!

@JelleZijlstra JelleZijlstra merged commit 4075944 into psf:main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ttibsi @onerandomusername @JelleZijlstra @cooperlees