Add a missing space #2590
Merged
Add a missing space #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DEPRECATION: Python 2 support will be removed in the first stable releaseexpected in January 2022` - > `DEPRECATION: Python 2 support will be removed in the first stable release expected in January 2022`
|
A welcome quick fix for sure, thanks for submitting! I think the draft mode is unnecessary with a change this small. |
felix-hilden
approved these changes
Nov 5, 2021
|
The CI failures look unrelated. |
|
Yea.. tests is definitely not related and while I'm not sure what's up with primer it can't possibly be related to this change :) |
|
Thank you so much for your contribution! I realized this (very) dumb mistake after my deprecation PR was merged, it's great to see it fixed :D This project is only possible by contributions like these 🖤. You're awesome, @LordOfPolls. If you got any feedback on your experience contributing here please let me know via #2238. Have a wonderful day/night! |
JelleZijlstra
pushed a commit
that referenced
this pull request
Nov 16, 2021
`DEPRECATION: Python 2 support will be removed in the first stable releaseexpected in January 2022` - > `DEPRECATION: Python 2 support will be removed in the first stable release expected in January 2022`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nice and simple change, a space was missing which was causing some ugly text:
Original:
DEPRECATION: Python 2 support will be removed in the first stable releaseexpected in January 2022Now:
DEPRECATION: Python 2 support will be removed in the first stable release expected in January 2022Checklist - did you ...