Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instability due to trailing comma logic #2572

Merged
merged 9 commits into from Jan 29, 2022

Commits on Nov 18, 2021

  1. Copy the full SHA
    dd08fb1 View commit details
    Browse the repository at this point in the history
  2. Remove magic comma logic from can_omit_invisible_parens

    It was causing stability issues because the first pass
    could cause a "magic trailing comma" to appear, meaning
    that the second pass might get a different result. It's
    not critical.
    
    black-primer previously crashed on several projects due to instability, but now passes.
    The preexisting disabled tests can now be enabled. Added a new
    test for a case that came up in my testing.
    
    Some things format differently (with extra parens)
    nipunn1313 committed Nov 18, 2021
    Copy the full SHA
    7ac3be1 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Copy the full SHA
    9329b8e View commit details
    Browse the repository at this point in the history
  2. fix tests

    JelleZijlstra committed Jan 28, 2022
    Copy the full SHA
    76a7a9b View commit details
    Browse the repository at this point in the history
  3. don't format twice

    JelleZijlstra committed Jan 28, 2022
    Copy the full SHA
    b3922fc View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Copy the full SHA
    1d21126 View commit details
    Browse the repository at this point in the history
  2. test fixes

    JelleZijlstra committed Jan 29, 2022
    Copy the full SHA
    1e77ae4 View commit details
    Browse the repository at this point in the history
  3. format twice again

    There's one case in torture.py that it still fails on
    JelleZijlstra committed Jan 29, 2022
    Copy the full SHA
    b04aec1 View commit details
    Browse the repository at this point in the history
  4. fix torture again

    JelleZijlstra committed Jan 29, 2022
    Copy the full SHA
    5addf3e View commit details
    Browse the repository at this point in the history