Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run second pass of formatter #2549

Closed
wants to merge 1 commit into from
Closed

Run second pass of formatter #2549

wants to merge 1 commit into from

Commits on Oct 20, 2021

  1. Run second pass of formatter for real instead of in validation-only 

    Fixes psf#2488 and psf#2518

Admittedly, it doesn't fix the underlying issue. There are three
expected-failure tests in test_black.py, which prove the issue
(test_trailing_comma_optional_parens_stability{1,2,3})

This is a (somewhat terrible) bandaid which runs the entire formatter
twice to work around this problem. The problem appears preexisting
based on the disabled tests and the comments, so this feels like a
reasonable step-in-the-right-direction.
    @nipunn1313
    nipunn1313 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    2394664 View commit details
    Browse the repository at this point in the history